[SPARK-41520][SQL] Split AND_OR TreePattern to separate AND and OR TreePatterns#39064
Closed
kelvinjian-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-41520][SQL] Split AND_OR TreePattern to separate AND and OR TreePatterns#39064kelvinjian-db wants to merge 1 commit intoapache:masterfrom
kelvinjian-db wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
sigmod
approved these changes
Dec 15, 2022
Contributor
|
Can one of the admins verify this patch? |
gengliangwang
approved these changes
Dec 16, 2022
Member
|
+1, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed
AND_ORTreePattern, replaced with separateANDTreePattern andORTreePattern.Why are the changes needed?
This way we can be more fine-grained with how we match for AND/OR patterns, since in many cases we want to treat them separately.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No tests were added as there are not any existing unit tests for TreePatterns. Instead, I just made sure the existing relevant tests (e.g.
BooleanSimplificationSuite) passed.