Skip to content

[SPARK-41520][SQL] Split AND_OR TreePattern to separate AND and OR TreePatterns#39064

Closed
kelvinjian-db wants to merge 1 commit intoapache:masterfrom
kelvinjian-db:SPARK-41520-and-or-treepattern
Closed

[SPARK-41520][SQL] Split AND_OR TreePattern to separate AND and OR TreePatterns#39064
kelvinjian-db wants to merge 1 commit intoapache:masterfrom
kelvinjian-db:SPARK-41520-and-or-treepattern

Conversation

@kelvinjian-db
Copy link
Contributor

@kelvinjian-db kelvinjian-db commented Dec 15, 2022

What changes were proposed in this pull request?

Removed AND_OR TreePattern, replaced with separate AND TreePattern and OR TreePattern.

Why are the changes needed?

This way we can be more fine-grained with how we match for AND/OR patterns, since in many cases we want to treat them separately.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No tests were added as there are not any existing unit tests for TreePatterns. Instead, I just made sure the existing relevant tests (e.g. BooleanSimplificationSuite) passed.

@github-actions github-actions bot added the SQL label Dec 15, 2022
@kelvinjian-db kelvinjian-db changed the title [SPARK-41520] Split AND_OR TreePattern to separate AND and OR TreePatterns [SPARK-41520][SQL] Split AND_OR TreePattern to separate AND and OR TreePatterns Dec 15, 2022
@kelvinjian-db
Copy link
Contributor Author

@sigmod

@sigmod
Copy link
Contributor

sigmod commented Dec 15, 2022

@gengliangwang @cloud-fan

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@gengliangwang
Copy link
Member

+1, merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants